Add devcontainer config #33

Closed

Ghost wants to merge 0 commits from development into development

Ghost commented

2024-12-09 04:44:56 +00:00

(Migrated from codeberg.org)

Hi,

I'm not sure if this is useful for you or not but I was checking out what you are working on (nice work!) and I thought it might be so I figured I'd create a PR and you can use it if you want or discard it with no hard feelings :)

This is basically copy just a copy of your existing docker compose setup but put into a devcontainer setup so it can be mostly run from VS Code. Might make it easier for other people to mess around with maybe.

Cheers,

hads

Hi, I'm not sure if this is useful for you or not but I was checking out what you are working on (nice work!) and I thought it might be so I figured I'd create a PR and you can use it if you want or discard it with no hard feelings :) This is basically copy just a copy of your existing docker compose setup but put into a devcontainer setup so it can be mostly run from VS Code. Might make it easier for other people to mess around with maybe. Cheers, hads

Ghost commented

2024-12-09 04:45:30 +00:00

(Migrated from codeberg.org)

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
10620441	Triggered	Generic Password	d1c3dee3ce24712c773cfdc722a35e56339c959b	.devcontainer/docker-compose.yaml	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secret safely. Learn here the best practices.
Revoke and rotate this secret.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

#### ⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request. Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components. Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard. <details> <summary>🔎 Detected hardcoded secret in your pull request</summary> | GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [10620441](https://dashboard.gitguardian.com/workspace/282361/incidents/10620441) | Triggered | Generic Password | d1c3dee3ce24712c773cfdc722a35e56339c959b | .devcontainer/docker-compose.yaml | [View secret](https://github.com/MarkusThielker/next-ory/commit/d1c3dee3ce24712c773cfdc722a35e56339c959b#diff-e96a798889398aad623ee0fa8ef4d316b5a72a5383f4534acbe805619458f263R101) | </details> <details> <summary>🛠 Guidelines to remediate hardcoded secrets</summary> 1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_password#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation. </details> --- 🦉 [GitGuardian](https://dashboard.gitguardian.com/auth/login/?utm_medium=checkruns&utm_source=github&utm_campaign=cr1) detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Ghost commented

2024-12-13 23:25:45 +00:00

(Migrated from codeberg.org)

Thank you for your contribution and interest in this project!

I appreciate you taking the time to create this pull request for devcontainers. While this is a valuable addition in many projects, I'm currently working on this project solo and keeping the development process streamlined for my own workflow.

Additionally, I have no personal experience with devcontainers, which makes it difficult for me to properly review, maintain, and support this change at this time.

I'll definitely keep the concept of devcontainers in mind for future development and potentially learn more about them then. Thanks again for your understanding.

Thank you for your contribution and interest in this project! I appreciate you taking the time to create this pull request for devcontainers. While this is a valuable addition in many projects, I'm currently working on this project solo and keeping the development process streamlined for my own workflow. Additionally, I have no personal experience with devcontainers, which makes it difficult for me to properly review, maintain, and support this change at this time. I'll definitely keep the concept of devcontainers in mind for future development and potentially learn more about them then. Thanks again for your understanding.